FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

engine.wrap Ops by gselzer · Pull Request #283 · scijava/scijava · GitHub

/ scijava Public

engine.wrap Ops #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gselzer wants to merge 3 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 1 Commits 3 Checks 0 Files changed
Draft

engine.wrap Ops #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e7c585
WIP: Write wrapper focusers
gselzer Mar 6, 2024
b6cde53
WIP: Create a suite of ComplexType RAI wrappers
gselzer Mar 20, 2024
ef0f1df
BIG WIP: Engine.wrap + fixes
gselzer Feb 11, 2025
File filter

Filter by extension

Filter by extension .java  (8) .vm  (2) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 2 additions & 2 deletions scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/convert/Conversions.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,8 @@ private static Optional<ConvertedOpInfo> postprocessIdentity(OpInfo info,
return Optional.empty();
}
// And only applies when the mutable index was "converted" with identity
if (Ops.info(preConverters.get(ioIndex)).names().contains(
"engine.identity"))
var names = Ops.info(preConverters.get(ioIndex)).names();
if (names.contains("engine.identity") || names.contains("engine.wrap"))
{
// In this case, we need neither a postprocessor nor a copier,
// because the mutable output was directly edited.
Expand Down
2 changes: 2 additions & 0 deletions ...gine/src/main/java/org/scijava/ops/engine/matcher/convert/ConvertedInfoTreeGenerator.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
import org.scijava.ops.api.*;
import org.scijava.ops.engine.BaseOpHints;
import org.scijava.ops.engine.InfoTreeGenerator;
import org.scijava.ops.engine.matcher.impl.DefaultOpRequest;
import org.scijava.ops.engine.matcher.impl.InfoMatchingOpRequest;
import org.scijava.types.Nil;

/**
Expand Down
1 change: 0 additions & 1 deletion ...-engine/src/main/java/org/scijava/ops/engine/matcher/impl/RuntimeSafeMatchingRoutine.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
import org.scijava.ops.engine.matcher.OpMatcher;
import org.scijava.ops.engine.matcher.impl.MatchingUtils.TypeVarInfo;
import org.scijava.priority.Priority;
import org.scijava.struct.Member;
import org.scijava.common3.Types;
import org.scijava.types.infer.GenericAssignability;

Expand Down
784 changes: 406 additions & 378 deletions scijava-ops-image/src/main/java/org/scijava/ops/image/convert/ConvertImages.java
Show comments
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Back | FazBrowse Home | New Git URL