ScriptService: add getScript(String,String) signature - #390
Open
imagejan wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I refactored ScriptServiceTest a bit to initialize the Context in a @Before method, and dispose it @After the tests. @ctrueden what do you think about the re-use of the ScriptLanguage from ScriptInfoTest$BindingSizes? Should we instead make BindingSizes its own class within the tests? There are actually two nested ScriptLanguage implementations in the tests currently: ScriptInfoTest$BindingSizes and ScriptEngineTest$Rot13. |
Sorry, something went wrong.
imagejan
force-pushed
the
scriptinfo-from-string
branch
from
0b2e588 to
ab9dad2
Compare
September 3, 2020 18:36
imagejan
force-pushed
the
scriptinfo-from-string
branch
from
ab9dad2 to
fc00c05
Compare
December 18, 2020 19:10
This makes it easier to retrieve a ScriptInfo object from a script string (without going via File). Closes #389.
imagejan
force-pushed
the
scriptinfo-from-string
branch
from
fc00c05 to
0fc27eb
Compare
January 19, 2021 19:52
ctrueden
force-pushed
the
master
branch
3 times, most recently
from
53b6733 to
3dc99c9
Compare
November 7, 2023 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to retrieve a ScriptInfo object from a script string (without going via File).
Closes #389.