FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WidgetStyle: add javadoc and new method by imagejan · Pull Request #405 · scijava/scijava-common · GitHub

WidgetStyle: add javadoc and new method - #405

Merged
hinerm merged 1 commit into
masterfrom
more-widgetstyle
Sep 7, 2021
Merged

WidgetStyle: add javadoc and new method#405
hinerm merged 1 commit into
masterfrom
more-widgetstyle

Conversation

Copy link
Copy Markdown
Member

While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon (:), for cases like "format:#0.001".

See also scijava/scijava-ui-swing#52.

Copy link
Copy Markdown
Member Author

@ctrueden just saw your comment here: #384 (comment)

If we're free to change the API of WidgetStyle, we could consider a) changing the return type of getModifiers() from String[] to Set<String> or b) removing the getModifiers signature entirely.

Also, I'm still open to (re-)naming suggestions :-)

imagejan added a commit to scijava/scijava-ui-swing that referenced this pull request Nov 1, 2020
imagejan added a commit to scijava/scijava-ui-swing that referenced this pull request Jan 10, 2021
While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon, for cases like "format:#0.001".

See also scijava/scijava-ui-swing#52.

Copy link
Copy Markdown
Member Author

@hinerm do you think this can be merged? Or alternatively, we can adapt the API introduced in #384, but I'm afraid there has been a release by now, so it would be a breaking API change (although no SciJava component was using it yet) ...

Anyhow, I think it would be good to get this done, so we can proceed with scijava/scijava-ui-swing#54 and scijava/scijava-ui-swing#56.

Copy link
Copy Markdown

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/save-one-tiff-projection-from-a-current-view-in-bdv/33965/28

hinerm merged commit e406d63 into master Sep 7, 2021
imagejan deleted the more-widgetstyle branch September 7, 2021 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL