IOService recognizes a new 3rd state of loading data - #430
Closed
xulman wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This was referenced Feb 6, 2022
Copy link
Copy Markdown
Author
|
deprecated in favour of SelfShowableContent -> #473 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IOService allows (likely among other functionalities) a client-code to be hooked into the drag&drop chain of openers. Each opener in this chain is asked if it supportsOpen() and Object open(final Location source) is called on the first opener supporting the given input.
However, the open() call expects data to be loaded that, in the drag&drop scenario, is directly submitted to uiService.show().
This PR attempts to solve the use case when the open() actually wants to use its own way of presenting the loaded data. The proposal defines a special, unique, signalling object IOService.GOVERNING_APP_STARTED that must be returned from the open() calls in such cases, that is, when 3rd party app is opened on the incoming (dropped-in) file.
This PR works in conjunction with fiji/IO#18