refactor: delay import of pandas until needed - #87
Merged
ctrueden merged 2 commits intoAug 23, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tlambert03
marked this pull request as ready for review
August 23, 2025 13:10
ctrueden
approved these changes
Aug 23, 2025
ctrueden
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Awesome! Glad to know there is a way to register these converters more efficiently.
Sorry, something went wrong.
Comment thread
src/scyjava/_convert.py
| ), | ||
| ] | ||
| if _import_pandas(required=False): | ||
| if find_spec("pandas"): |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is a great trick, thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #86, I noticed that scyjava was greedily importing pandas, even when it wasn't being used. Pandas is somewhat large and can slow down startup; so it would be nice to delay that until we know we need it.
The traditional pattern of try import just to know whether something is importable can be improved:
this PR removes the _import_X(required=False) pattern in place of importlib.util.find_spec