_PyStringTransformerMiddleware.transform_string assigned the (value, error) tuple returned by _transform_python_value_string directly to string.value, instead of unpacking it like transform_entry does. As a result:
After LatexDecodingMiddleware/LatexEncodingMiddleware, String.value was a tuple, not a str.
Transformation errors on @string blocks were silently swallowed (no MiddlewareErrorBlock, unlike for entries).
Fix
transform_string now unpacks the tuple and, on error, returns a MiddlewareErrorBlock wrapping a PartialMiddlewareException — mirroring the transform_entry behavior.
Tests
En-/decoding a String block yields a str with the transformed value.
A failing transformation on a String block surfaces as a MiddlewareErrorBlock in library.failed_blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_PyStringTransformerMiddleware.transform_string assigned the (value, error) tuple returned by _transform_python_value_string directly to string.value, instead of unpacking it like transform_entry does. As a result:
Fix
transform_string now unpacks the tuple and, on error, returns a MiddlewareErrorBlock wrapping a PartialMiddlewareException — mirroring the transform_entry behavior.
Tests
Fixes #529
🤖 Generated with Claude Code