Silence deprecations / PHP 8.4 compatibility (non-breaking) - #33
Open
redcuillin wants to merge 1 commit into
Open
redcuillin wants to merge 1 commit into
redcuillin wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…roved PHP 8.4 compatibility. Update .gitignore to include .phpunit.result.cache.
Copy link
Copy Markdown
|
❌ The last analysis has failed. |
Sorry, something went wrong.
Closed
rudolfbyker
approved these changes
May 20, 2026
rudolfbyker
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM overall, but made one suggestion for improvement.
Sorry, something went wrong.
Comment thread
src/Fields/SerializableField.php
| trait SerializableField | ||
| { | ||
| public function jsonSerialize(): array|string | ||
| public function jsonSerialize(): mixed |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This is technically correct, but loses useful information. Suggestion: Add the missing information via PHPDoc, like this:
/**
* @returns array|string
*/
public function jsonSerialize(): mixedThe same applies to many other places in this PR.
Sorry, something went wrong.
Comment thread
src/Importers/XmlImporter.php
Comment on lines
+42
to
+46
| $source = simplexml_load_string($data, 'SimpleXMLElement', 0, $ns, $isPrefix); | ||
| if (false === $source) { | ||
| throw new XmlException(libxml_get_errors()); | ||
| } | ||
| $this->source = $source; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good catch!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type hinting and return types for PHP 8.4 compatibility. Update .gitignore to include .phpunit.result.cache.
Silences deprecation warnings if using PHP8.4 without breaking compatibility with earlier versions.