FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Native Sumcheck Layer Evaluation by darth-cy · Pull Request #8 · scroll-tech/openvm · GitHub

/ openvm Public
forked from openvm-org/openvm

Native Sumcheck Layer Evaluation - #8

Merged
kunxian-xia merged 44 commits into
mainfrom
feat/native_sumcheck_layer_eval
Nov 25, 2025
ConversationCommits (44)ChecksFiles changed
Merged

Native Sumcheck Layer Evaluation#8
kunxian-xia merged 44 commits into
mainfrom
feat/native_sumcheck_layer_eval

Conversation

darth-cy commented Sep 17, 2025 •
edited by kunxian-xia
Loading

Copy link
Copy Markdown

Summary

  • Add a custom opcode SUMCHECK_LAYER_EVAL for calculating layer evaluation.

    1. For GKR product iop, the main sumcheck has the form v'[b] = v[b,0] * v[b,1];
    2. For GKR logup iop, the main sumcheck has the form p'[b] = p[b,0]*q[b,1] + p[b,1]*q[b,0], q'[b] = q[b,0]*q[b,1]

  • The new added opcode supports two modes:

    1. calculate the expected evaluation of two types of sumchecks;
    2. calculate the expected value of next layer p[r] = eq(0,r)*p[0] + eq(1,r)*p[1].

Layout

Each row is able to process 1 product sumcheck or 1 logup sumcheck.

Performance

layout for new chip NativeSumcheck

air quotient deg prep cols main cols perm cols
NativeSumcheckAir Quotient Deg = 2 Prep Cols = 0 Main Cols = [110] Perm Cols = [132]

Add native sumcheck chip
ac02ac5
Complete sumcheck layer execution logic
d18ef80
Remove debug flags
7846a3c
Add variation
99c9f4c
Cherry pick column reduction commits
1e06dc7
Add record assignments
8c33bc6
Adjust unit test
5f1903e
Correct header row register reads
8f780da
Correct header row register reads
f9023a5
Correct header row register read
1ae5182
Correct rw records for prod rows
49f337f
Debug constraints
5d6a236
Debug constraints
368cb99
Debug constraints
0785a3e
Debug constraints
de79174
Debug constraints
e1194c2
Debug constraints
6aaea67
Debug constraints
75df4f3
Degree reduction
2cbbb78
Reduce degree
7e56928
Reduce degree
18f0b75
Disable debug flag
7096b8b
Debug constraints
25a72ba
Recover constraints
a43bd22
Debug constraints
5b50b5b
Debug constraints
12fe6fd
Debug constraints
21a8971
Debug constraints
8ad853a
Debug constraints:
4d28b21
Debug constraints
7be1fd8
darth-cy marked this pull request as draft September 25, 2025 20:09
darth-cy marked this pull request as ready for review September 29, 2025 01:56
kunxian-xia self-requested a review November 6, 2025 01:53
kunxian-xia reviewed Nov 17, 2025
View reviewed changes
Comment thread extensions/native/compiler/src/asm/instruction.rs
Comment thread extensions/native/compiler/src/ir/sumcheck.rs
kunxian-xia reviewed Nov 17, 2025
View reviewed changes
Comment thread extensions/native/circuit/src/sumcheck/chip.rs Outdated
Comment thread extensions/native/compiler/src/lib.rs Outdated
Comment thread extensions/native/compiler/src/ir/sumcheck.rs Outdated
kunxian-xia reviewed Nov 17, 2025
View reviewed changes
Comment thread extensions/native/circuit/src/sumcheck/air.rs Outdated

self.memory_bridge
.read(
MemoryAddress::new(self.address_space, register_ptrs[0] + AB::F::from_canonical_usize(EXT_DEG * 2 - 1) + curr_prod_n),

kunxian-xia Nov 17, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why -1 ?

kunxian-xia Nov 17, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see, since curr_prod_n starts from 1.

darth-cy Nov 23, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The formula is rewritten to make sure it's clear the -1 is grouped with curr_prod_n. Comment added.

Comment thread extensions/native/circuit/src/sumcheck/air.rs Outdated

self.memory_bridge
.read(
MemoryAddress::new(self.address_space, register_ptrs[0] + AB::F::from_canonical_usize(EXT_DEG * 2 - 1) + ctx[1] + curr_logup_n),

kunxian-xia Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why -1?

darth-cy Nov 23, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The formula is rewritten to make sure it's clear the -1 is grouped with curr_logup_n. Comment added.

kunxian-xia mentioned this pull request Nov 19, 2025
Open
8 tasks
kunxian-xia merged commit 8c2d257 into main Nov 25, 2025
2 of 28 checks passed
kunxian-xia mentioned this pull request Nov 27, 2025
Merged
kunxian-xia added a commit that referenced this pull request Nov 30, 2025
Pick #8 (#17)
102bd1f 
* wip

* wip2

* wip3

* wip4

* wip5

* replace variable position by name

* wip6

* wip7

* clippy

* wip8

* wip9

* wip10

* wip11

* wip12

* wip13

* wip14

* wip15

* clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
kunxian-xia kunxian-xia left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL