upgrade circuit to 0.5.2 by lispc · Pull Request #1703 · scroll-tech/scroll · GitHub

Purpose or design rationale of this PR

coordinator: re-build docker
prover: use 0.5.2 assets

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
docs: Documentation-only changes
feat: A new feature
fix: A bug fix
perf: A code change that improves performance
refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

No, this PR doesn't involve a new deployment, git tag, docker image tag
Yes

Breaking change label

Does this PR have the breaking-change label?

No, this PR is not a breaking change
Yes

Summary by CodeRabbit

Chores
- Updated certain dependencies to track a development branch instead of a fixed release candidate.
- Minor formatting improvement by adding a newline at the end of the configuration section.
- Updated version tag to v4.5.32.

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The dependency references for three workspace packages in Cargo.toml were updated from a specific git tag (v0.5.0rc1) to a branch (feat/0.5.1). Additionally, a newline was appended at the end of the file. The try_fetch_block_witness method in rpc_client.rs was refactored to use a single WitnessBuilder instance, removing fallback logic for fetching the previous block's disk root. The version tag string in common/version/version.go was updated from "v4.5.31" to "v4.5.32".

Changes

File	Change Summary
Cargo.toml	Updated three workspace dependencies to track a git branch instead of a tag; added newline.
crates/l2geth/src/rpc_client.rs	Refactored try_fetch_block_witness to consolidate witness building with a single builder; removed fallback fetch.
common/version/version.go	Updated version tag string from "v4.5.31" to "v4.5.32".

Estimated code review effort

2 (~15 minutes)

Possibly related PRs

bump to v4.5.31 #1700: Version tag update from "v4.5.31" to "v4.5.32", continuing the version bump sequence.
fix(build): image building #1603: Related version tag update in the same file, from "v4.4.88" to "v4.4.89".
feat: openvm v0.3.0 #1648: Changes dependency references of the same crates but from fixed tags to a branch, similar in scope.

Suggested reviewers

zimpha
johnsonjie

Poem

In the garden of code where dependencies grow,
We switched from a tag to a branch, don’t you know?
Witnesses built with care, no fetch to delay,
Streamlined and neat, they hop on their way!
A newline’s small gift, in the code it does glow—
🐇✨ Happy hops as the changes flow!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e447b0 and 71cca27.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

Cargo.toml (2 hunks)

🧠 Learnings (1) 📓 Common learnings

Learnt from: colinlyguo
PR: scroll-tech/scroll#1530
File: tests/integration-test/go.mod:21-21
Timestamp: 2024-10-20T15:30:18.084Z
Learning: In the `tests/integration-test` folder, updates to import statements or dependencies are not necessary since it's only used for testing purposes.

🧰 Additional context used 🧠 Learnings (1) 📓 Common learnings

Learnt from: colinlyguo
PR: scroll-tech/scroll#1530
File: tests/integration-test/go.mod:21-21
Timestamp: 2024-10-20T15:30:18.084Z
Learning: In the `tests/integration-test` folder, updates to import statements or dependencies are not necessary since it's only used for testing purposes.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: tests

🔇 Additional comments (1)

Cargo.toml (1)
68-68: EOF newline addition looks good

Adding the trailing newline fulfils POSIX conventions and avoids editor warnings. No further action needed.

…to feat/circuit-0.5.1

upgrade circuit to 0.5.1

71cca27

lispc changed the title WIP upgrade circuit to 0.5.1 upgrade circuit to 0.5.1 Jul 22, 2025

lispc marked this pull request as ready for review July 22, 2025 12:14

coderabbitai Bot reviewed Jul 22, 2025

View reviewed changes

Comment thread Cargo.toml

georgehao previously approved these changes Jul 22, 2025

View reviewed changes

colinlyguo previously approved these changes Jul 22, 2025

View reviewed changes

roylou reviewed Jul 22, 2025

View reviewed changes

Comment thread Cargo.toml

fix(l2geth): update after disk-root not supported (#1704 )

ebbaddd

lispc dismissed stale reviews from colinlyguo and georgehao via ebbaddd July 22, 2025 23:19

georgehao added the bump-version Bump the version tag for deployment label Jul 23, 2025

georgehao and others added 3 commits July 23, 2025 01:16

chore: auto version bump [bot]

b8045ef

update zkvm-prover

4da8d84

Merge branch 'feat/circuit-0.5.1' of github.com:scroll-tech/scroll in…

572d991

…to feat/circuit-0.5.1

lispc changed the title upgrade circuit to 0.5.1 upgrade circuit to 0.5.2 Jul 23, 2025

georgehao approved these changes Jul 23, 2025

View reviewed changes

jonastheis approved these changes Jul 23, 2025

View reviewed changes

georgehao merged commit 67b0555 into develop Jul 23, 2025
3 checks passed

georgehao deleted the feat/circuit-0.5.1 branch July 23, 2025 02:52

coderabbitai Bot mentioned this pull request Jul 23, 2025

circuit-0.5.2 #1705

Merged

13 tasks

coderabbitai Bot mentioned this pull request Aug 27, 2025

[Feat] Prover loading assets (circuits) dynamically #1717

Merged

upgrade circuit to 0.5.2 by lispc · Pull Request #1703 · scroll-tech/scroll · GitHub

Uh oh!

upgrade circuit to 0.5.2 - #1703

upgrade circuit to 0.5.2#1703
georgehao merged 5 commits into
developfrom
feat/circuit-0.5.1

lispc commented Jul 22, 2025 •
edited
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 22, 2025 •
edited
Loading

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

upgrade circuit to 0.5.2 by lispc · Pull Request #1703 · scroll-tech/scroll · GitHub

Uh oh!

upgrade circuit to 0.5.2 - #1703

upgrade circuit to 0.5.2#1703georgehao merged 5 commits intodevelopscroll-tech/scroll:developfrom feat/circuit-0.5.1scroll-tech/scroll:feat/circuit-0.5.1Copy head branch name to clipboard

Conversation

lispc commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose or design rationale of this PR

PR title

Deployment tag versioning

Breaking change label

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

upgrade circuit to 0.5.2#1703
georgehao merged 5 commits into
developfrom
feat/circuit-0.5.1

lispc commented Jul 22, 2025 •
edited
Loading

coderabbitai Bot commented Jul 22, 2025 •
edited
Loading