[FIX] Compatible with current prover (before 0.5.6) by noel2004 · Pull Request #1732 · scroll-tech/scroll · GitHub

This PR updated the dep of zkvm-prover with a trivial fixing so it can be compatible with the proof send from current prover being deployed (before 0.5.6)

Updating in zkvm-prover: scroll-tech/zkvm-prover#180

Summary by CodeRabbit

Chores
- Bumped app version to v4.5.45 for release tracking and visibility.
- Updated underlying proof/verification dependencies to the latest revisions to stay aligned with upstream.
- Users can expect minor stability and performance improvements; no changes to interfaces or workflows.
- No migration or configuration changes required; existing integrations continue to work as before.
- Includes routine maintenance that may incorporate upstream fixes and compatibility updates.

Walkthrough

Updates pinned git revisions for three zkVM workspace dependencies in Cargo.toml and bumps the internal version tag from v4.5.44 to v4.5.45 in common/version/version.go.

Changes

Cohort / File(s)	Summary
Dependency pin updates Cargo.toml	Update git rev from 89a2dc1 to ad0efe7 for scroll-zkvm-prover, scroll-zkvm-verifier, and scroll-zkvm-types. No other config changes.
Version bump common/version/version.go	Increment tag string from "v4.5.44" to "v4.5.45". No logic changes to version computation.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

bump version to v4.5.44 #1731 — Prior adjacent tag bump in common/version/version.go (v4.5.43→v4.5.44)
feat: bump zkvm-prover #1614 — Version tag bump in the same file; similar change pattern
bump to v4.5.31 #1700 — Another tag update in common/version/version.go

Suggested labels

bump-version

Suggested reviewers

jonastheis
roynalnaruto
yiweichi

Poem

I twitch my whiskers, tag hops a notch,
v4.5.45—tick of the watch.
Pins realigned to a fresher tree,
Prover and friends in lockstep glee.
A carrot toast to tidy revs—
onward the burrow of shipping devs! 🥕

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/prover_compatility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Actionable comments posted: 0

🧹 Nitpick comments (1)

Cargo.toml (1)

20-22: Prefer full 40-char SHA for rev to avoid future ambiguity.

Short SHAs generally work but can become ambiguous over time; using the full commit hash improves robustness and auditability. No functional change required.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7ff5b19 and 3042cd2.

⛔ Files ignored due to path filters (2)

Cargo.lock is excluded by !**/*.lock
crates/gpu_override/Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

Cargo.toml (1 hunks)
common/version/version.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: tests

🔇 Additional comments (4)

Cargo.toml (2)

20-22: LGTM: pinned zkVM suite to a single commit across prover/verifier/types.

Consistent rev across the three crates matches the PR goal of restoring compatibility with pre-0.5.6 proofs.

20-22: No action needed: Manifests and lockfile are consistent
Manifests reference rev ad0efe7 for all three scroll-zkvm modules, and Cargo.lock pins that same commit (long SHA ad0efe750d5f03781f28037c312e50400ac22a8d) with no other overrides.

common/version/version.go (2)

8-8: Version tag bump to v4.5.45 looks good.

Matches the dependency tweak and will surface in the composite Version string at runtime.

8-8: Confirm release/process alignment.

After merge, ensure a corresponding Git tag/release is cut for v4.5.45 and that CI injects non-default ZkVersion (prover/openvm commit-ids) so production builds don’t report “000000-000000”.

update dep

c9b0256

bump version

3042cd2

coderabbitai Bot reviewed Sep 2, 2025

View reviewed changes

georgehao approved these changes Sep 2, 2025

View reviewed changes

noel2004 requested a review from lispc September 2, 2025 10:17

lispc approved these changes Sep 2, 2025

View reviewed changes

noel2004 merged commit a5a7844 into develop Sep 2, 2025
3 checks passed

noel2004 deleted the fix/prover_compatility branch September 2, 2025 10:20

coderabbitai Bot mentioned this pull request Sep 3, 2025

[Fix] Compatible with prover from 4.5.33 #1733

Closed

coderabbitai Bot mentioned this pull request Sep 16, 2025

[Feat] Update zkvm to 0.6 (use openvm 1.4) #1736

Merged

coderabbitai Bot mentioned this pull request Oct 16, 2025

[Feat] For prover 4.6.1 #1742

Merged

3 tasks

coderabbitai Bot mentioned this pull request Nov 25, 2025

Optimization for prover #1761

Closed

coderabbitai Bot mentioned this pull request Dec 17, 2025

Optimization for prover (override #1761) #1774

Closed

coderabbitai Bot mentioned this pull request Feb 20, 2026

Fix/validium prover #1794

Closed

coderabbitai Bot mentioned this pull request Mar 2, 2026

chore: openvm 1.6 #1783

Merged

[FIX] Compatible with current prover (before 0.5.6) by noel2004 · Pull Request #1732 · scroll-tech/scroll · GitHub

Uh oh!

[FIX] Compatible with current prover (before 0.5.6) - #1732

[FIX] Compatible with current prover (before 0.5.6)#1732
noel2004 merged 2 commits into
developfrom
fix/prover_compatility

noel2004 commented Sep 2, 2025 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 2, 2025 •
edited
Loading

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[FIX] Compatible with current prover (before 0.5.6) by noel2004 · Pull Request #1732 · scroll-tech/scroll · GitHub

Uh oh!

[FIX] Compatible with current prover (before 0.5.6) - #1732

[FIX] Compatible with current prover (before 0.5.6)#1732noel2004 merged 2 commits intodevelopscroll-tech/scroll:developfrom fix/prover_compatilityscroll-tech/scroll:fix/prover_compatilityCopy head branch name to clipboard

Conversation

noel2004 commented Sep 2, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[FIX] Compatible with current prover (before 0.5.6)#1732
noel2004 merged 2 commits into
developfrom
fix/prover_compatility

noel2004 commented Sep 2, 2025 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Sep 2, 2025 •
edited
Loading