rollup/internal/controller/watcher/chunk_proposer.go (1)

135-148: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Ignore gorm.ErrRecordNotFound to prevent startup warnings on a fresh database.

Like BatchProposer.initializeMetrics, consider explicitly ignoring gorm.ErrRecordNotFound. Without this check, starting the service with an empty database will trigger a warning log since GetLatestChunk returns ErrRecordNotFound when no chunks exist yet.

♻️ Proposed refactor

 func (p *ChunkProposer) initializeMetrics(ctx context.Context) {
 	latestChunk, err := p.chunkOrm.GetLatestChunk(ctx)
 	if err != nil {
+		if errors.Is(err, gorm.ErrRecordNotFound) {
+			return // no chunks proposed yet, nothing to seed
+		}
 		log.Warn("failed to initialize chunk propose block height metric", "err", err)
 		return
 	}

Ensure the "errors" and "gorm.io/gorm" packages are imported at the top of the file if you apply this fix.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@rollup/internal/controller/watcher/chunk_proposer.go` around lines 135 - 148,
Update ChunkProposer.initializeMetrics to treat gorm.ErrRecordNotFound from
GetLatestChunk as an expected empty-database condition: detect it with errors.Is
and return without logging, while preserving the warning for other errors and
the metric update for an existing latestChunk. Add the required errors and gorm
imports.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@rollup/internal/controller/watcher/chunk_proposer.go`:
- Around line 135-148: Update ChunkProposer.initializeMetrics to treat
gorm.ErrRecordNotFound from GetLatestChunk as an expected empty-database
condition: detect it with errors.Is and return without logging, while preserving
the warning for other errors and the metric update for an existing latestChunk.
Add the required errors and gorm imports.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2cda3dd4-02e1-4b88-9350-e9276d4756f9

Reviewing files that changed from the base of the PR and between 79c1f8c and dee9965.

• common/version/version.go
• rollup/internal/controller/relayer/l2_relayer.go
• rollup/internal/controller/watcher/batch_proposer.go
• rollup/internal/controller/watcher/chunk_proposer.go
• rollup/internal/controller/watcher/l1_watcher.go
• rollup/internal/controller/watcher/l2_watcher.go
• rollup/internal/orm/batch.go