Actionable comments posted: 1

coordinator/internal/logic/provertask/chunk_prover_task.go (1)

272-285: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use ctx.Copy() for consistent context propagation.

For consistency with batch_prover_task.go, bundle_prover_task.go, and the rest of this file, consider using ctx.Copy() when passing the Gin context to the ORM methods.

♻️ Proposed refactor

 func (cp *ChunkProverTask) recoverAttempts(ctx *gin.Context, taskCtx *proverTaskContext, chunkTask *orm.Chunk) {
 	if taskCtx.hasAssignedTask == nil {
-		if err := cp.chunkOrm.RefundAttemptsByHash(ctx, chunkTask.Hash); err != nil {
+		if err := cp.chunkOrm.RefundAttemptsByHash(ctx.Copy(), chunkTask.Hash); err != nil {
 			log.Error("failed to refund chunk attempts", "hash", chunkTask.Hash, "error", err)
 		}
 		return
 	}
-	if err := cp.chunkOrm.DecreaseActiveAttemptsByHash(ctx, chunkTask.Hash); err != nil {
+	if err := cp.chunkOrm.DecreaseActiveAttemptsByHash(ctx.Copy(), chunkTask.Hash); err != nil {
 		log.Error("failed to recover chunk active attempts", "hash", chunkTask.Hash, "error", err)
 	}
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@coordinator/internal/logic/provertask/chunk_prover_task.go` around lines 272
- 285, Update recoverAttempts to pass a copied Gin context to both
RefundAttemptsByHash and DecreaseActiveAttemptsByHash, matching the context
propagation pattern used elsewhere. Use ctx.Copy() at each ORM call while
preserving the existing refund and decrement behavior.

coordinator/internal/controller/api/get_task.go (1)

139-151: 🚀 Performance & Scalability | 🔵 Trivial | 💤 Low value

Return pre-sorted slice directly for default task types.

When TaskTypes is empty, you can return the default task types in priority order directly to skip the sorting overhead.

♻️ Proposed refactor

-	if len(proofTypes) == 0 {
-		proofTypes = []message.ProofType{
-			message.ProofTypeChunk,
-			message.ProofTypeBatch,
-			message.ProofTypeBundle,
-		}
-	}
-
-	// Bundle (3) > Batch (2) > Chunk (1)
-	sort.Slice(proofTypes, func(i, j int) bool {
-		return proofTypes[i] > proofTypes[j]
-	})
-	return proofTypes
+	if len(proofTypes) == 0 {
+		return []message.ProofType{
+			message.ProofTypeBundle,
+			message.ProofTypeBatch,
+			message.ProofTypeChunk,
+		}
+	}
+
+	// Bundle (3) > Batch (2) > Chunk (1)
+	sort.Slice(proofTypes, func(i, j int) bool {
+		return proofTypes[i] > proofTypes[j]
+	})
+	return proofTypes

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@coordinator/internal/controller/api/get_task.go` around lines 139 - 151,
Update the proofTypes defaulting logic in the surrounding task-type helper to
return the default ProofType slice directly in priority order when no task types
are provided, bypassing sort.Slice for that path. Preserve sorting for
explicitly supplied task types and keep the existing Bundle > Batch > Chunk
ordering.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@coordinator/internal/orm/orm_test.go`:
- Around line 143-163: Extend the refund tests around the existing chunk case
and the corresponding batch and bundle cases to cover two active/total attempts
before refunding one, asserting the counters become 1/1 and the status remains
ProvingTaskAssigned. Reuse the existing ORM setup and refund APIs for each
resource, while preserving the current 1/1 → 0/0 unassignment coverage.

---

Nitpick comments:
In `@coordinator/internal/controller/api/get_task.go`:
- Around line 139-151: Update the proofTypes defaulting logic in the surrounding
task-type helper to return the default ProofType slice directly in priority
order when no task types are provided, bypassing sort.Slice for that path.
Preserve sorting for explicitly supplied task types and keep the existing Bundle
> Batch > Chunk ordering.

In `@coordinator/internal/logic/provertask/chunk_prover_task.go`:
- Around line 272-285: Update recoverAttempts to pass a copied Gin context to
both RefundAttemptsByHash and DecreaseActiveAttemptsByHash, matching the context
propagation pattern used elsewhere. Use ctx.Copy() at each ORM call while
preserving the existing refund and decrement behavior.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f6e6f610-d3d3-4a98-a3bb-a1cefdbf7dd6

Reviewing files that changed from the base of the PR and between 788fdf0 and 99ae23b.

• coordinator/internal/controller/api/get_task.go
• coordinator/internal/logic/provertask/batch_prover_task.go
• coordinator/internal/logic/provertask/bundle_prover_task.go
• coordinator/internal/logic/provertask/chunk_prover_task.go
• coordinator/internal/orm/batch.go
• coordinator/internal/orm/bundle.go
• coordinator/internal/orm/chunk.go
• coordinator/internal/orm/orm_test.go
• coordinator/test/api_test.go