fix: don't enforce identical df index on {obs,var}m - #2641
Open
ilan-gold wants to merge 5 commits into
Open
ilan-gold wants to merge 5 commits into
ilan-gold wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2641 +/- ##
==========================================
- Coverage 87.60% 84.84% -2.76%
==========================================
Files 49 49
Lines 8123 8110 -13
==========================================
- Hits 7116 6881 -235
- Misses 1007 1229 +222
|
Sorry, something went wrong.
ilan-gold
marked this pull request as ready for review
September 8, 2026 14:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See scverse/anndata-rs#44 for more info, but since this isn't technically in our spec (and I find it wasteful in any case to enforce), I think removing it is reasonable. I've already added a note to revisit this in #2060.
We could in theory warn users about the mismatch, but that would mean that everything produced by rustar-alginer (without a fix there enforcing the duplication of the index across multi-dim mappings) would yield the warning.
I'm open to suggestions, but this seemed the least invasive!