FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgraded embedded minio chart to latest release v11.9.4 (closes #755) by rfelber · Pull Request #1340 · secureCodeBox/secureCodeBox · GitHub

/ secureCodeBox Public

Upgraded embedded minio chart to latest release v11.9.4 (closes #755) - #1340

Merged
the-simmon merged 1 commit into
mainfrom
feature/upgrade-minio-chart
Oct 5, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Upgraded embedded minio chart to latest release v11.9.4 (closes #755)#1340
the-simmon merged 1 commit into
mainfrom
feature/upgrade-minio-chart

Conversation

rfelber commented Sep 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Upgraded embedded minio chart to latest release v11.9.4 (closes #755)

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Upgraded embedded minio chart to latest release
cb1cf02 
(closes #755)

Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
rfelber added dependencies Pull requests that update a dependency file maintenance breaking Changes requiring a major release labels Sep 3, 2022
rfelber self-assigned this Sep 3, 2022

github-actions Bot commented Sep 3, 2022 •
edited
Loading

Copy link
Copy Markdown

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ GIT git_diff yes no 0.2s
⚠️ SPELL misspell 3 1 0.07s
⚠️ YAML prettier 3 1 1.17s
✅ YAML v8r 3 0 3.06s
⚠️ YAML yamllint 3 1 0.25s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

rfelber added this to the v4.0.0 milestone Sep 3, 2022
J12934 reviewed Sep 5, 2022
View reviewed changes
Comment thread operator/templates/manager/manager.yaml
secretKeyRef:
name: "{{ .Release.Name }}-minio"
key: accesskey
key: root-user

J12934 Sep 5, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This will also require tweaks to the installation docs: https://www.securecodebox.io/docs/getting-started/installation#accessing-the-included-minio-instance

rfelber Sep 5, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good Point, thx for the hint

the-simmon reviewed Sep 7, 2022
View reviewed changes
Comment thread operator/Chart.lock
Comment on lines +3 to +6
repository: https://charts.bitnami.com/bitnami
version: 11.9.4
digest: sha256:dcd5c66891556818e8955c7aabd358ca8c87928291b1918611cb333184dd5109
generated: "2022-09-03T17:30:31.769197+02:00"

the-simmon Sep 7, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is there are reason why you use the bitnami chart instead of the official chart mentioned here? The discussion never came to a final conclusion on what to use.

rfelber Oct 5, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

i tried the official chart first, but it didn't work and seems to lack some support. Thats why i switched to the bitnami chart. It leaves the impression of a more stable and mature setup.

the-simmon merged commit 84185a5 into main Oct 5, 2022
the-simmon deleted the feature/upgrade-minio-chart branch October 5, 2022 16:28
Ilyesbdlala added a commit that referenced this pull request Oct 12, 2022
fix(minio): Fixed port forward script to fit change to bitnami minio …
ce8c631 
…charts in #1340

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala mentioned this pull request Oct 12, 2022
Merged
4 tasks
Ilyesbdlala added a commit that referenced this pull request Oct 12, 2022
fix(minio): Fixed port forward script to fit change to bitnami minio …
15570d8 
…charts in #1340

In #1340 we changed from using official minio helm charts to the bitnami minio charts.
This is done because we deemed them more stable and mature
As a result the secrets json file has a different schema:
.data.accesskey --> .data.root-user
.data.secretkey --> .data.root-password
The exposed ports are also now divided into API:9000 and Console:9001
src: https://artifacthub.io/packages/helm/bitnami/minio

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala mentioned this pull request Feb 2, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

J12934 J12934 left review comments
the-simmon the-simmon approved these changes

Assignees

rfelber

Labels

breaking Changes requiring a major release dependencies Pull requests that update a dependency file maintenance

Projects

secureCodeBox
Archived in project

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Update Minio Version used in Operator Helm Chart

3 participants

Back | FazBrowse Home | New Git URL