Added a crontab configuration option to scheduledScans - #1722
Merged
J12934 merged 18 commits intoJul 14, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
🦙 MegaLinter status: ⚠️ WARNING
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Sorry, something went wrong.
Ilyesbdlala
force-pushed
the
feature/scheduledscan-cronjob
branch
from
062d04d to
241c10b
Compare
June 6, 2023 13:07
Copy link
Copy Markdown
Member
Author
|
Current status: Cronjob configuration works (tested manually), However no unit test have been implemented. Unit tests are implemented that use polling to test if the cronjob has started. This is slower by a maximum of 60 seconds and a minimum of 0 seconds. the slow test has the golang build tag "slow" and other/fast tests have the tag "fast". |
Sorry, something went wrong.
Ilyesbdlala
force-pushed
the
feature/scheduledscan-cronjob
branch
from
241c10b to
5ebb84a
Compare
June 13, 2023 09:29
Ilyesbdlala
marked this pull request as ready for review
June 13, 2023 09:30
Ilyesbdlala
force-pushed
the
feature/scheduledscan-cronjob
branch
from
038ebaa to
e750f61
Compare
June 16, 2023 10:06
J12934
reviewed
Jul 10, 2023
Comment thread
operator/controllers/execution/suite_test.go
Outdated
Comment thread
operator/controllers/execution/scheduledscan_controller.go
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
fakeClock can fake the passing of time Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…ion is found and included the changes to FakeClock. It will be however later changed depending on the solution Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
… Cron Schedule tests This minimizes how much the test is slowed down (slower by between 0 and 50 seconds) Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This is done to make sure that any edge cases do not fail the tests we still expect to be a maximum 60s Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
fast tests can be called by "make test-fast" and all tests will run when command "make test" is used. This is done to keep the CI workflow as usual Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…of scheduledScan Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala
force-pushed
the
feature/scheduledscan-cronjob
branch
from
dc44598 to
21fc70b
Compare
July 14, 2023 13:36
J12934
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #150
Current status: Cronjob configuration works (tested manually), However no unit test have been implemented. Unit tests are implemented that use polling to test if the cronjob has started. This is slower by a maximum of 60 seconds and a minimum of 0 seconds. the slow test has the golang build tag "slow" and other/fast tests have the tag "fast".
Calling make test runs all tests i.e "slow and fast"
Calling make test-fast runs only the tests with "fast" tag.
Checklist