Fix Crash in DefectDojo Hook for Scans without Parameters - #2275
Merged
J12934 merged 17 commits intoFeb 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
✅ Deploy Preview for docs-securecodebox canceled.
|
Sorry, something went wrong.
So we can split the method better in further refactorings. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Get them out of the way, since they are used at various places. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Weltraumschaf
force-pushed
the
2272_npe_dd_import
branch
from
8ee75c2 to
c70e375
Compare
February 13, 2024 19:14
In Java getters are by convention methods which only returns a field. Java developers do not expect that getters operate on something else than "this" to retrieve an value. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Weltraumschaf
force-pushed
the
2272_npe_dd_import
branch
from
c70e375 to
bd980d4
Compare
February 13, 2024 19:37
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Found the test in the wrong package, after wondering why there are so much public API... Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
…rdcoded Newline Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
In Java getters are by convention methods which only returns a field. Java developers do not expect that getters operate on something else than "this" to retrieve an value. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Null should be avoid whenever possible because it leads to endless drama with NullPointerExceptions at runtime. In this particular case it is formatted as a string which will (maybe) convert to the string "null". Since this is an implementation detail of the Java SDK we can rely on that. Introduce the explicit string "n/a"" to indicate that there is no starting time. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Since generate is the important API the test cases should be before the ones for utility methods. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
This value may be null, but the join method requirres non-null. The fix is to check for null and defult to an empty list. This object creation should not be a performace problem. If to many descritions wil be generated this can be circumvented by default to a hardcoded string literal for empty/null parameters. Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Weltraumschaf
force-pushed
the
2272_npe_dd_import
branch
from
a195b09 to
fc574ec
Compare
February 13, 2024 20:57
Copy link
Copy Markdown
|
Sorry, something went wrong.
J12934
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.