Add a optional ttlSecondsAfterFinished field to scans to cleanup finished scans #2293 - #2631
Merged
J12934 merged 9 commits intoAug 30, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
✅ Deploy Preview for docs-securecodebox canceled.
|
Sorry, something went wrong.
J12934
requested changes
Aug 27, 2024
Comment thread
operator/apis/execution/v1/scan_types.go
Outdated
Comment thread
operator/controllers/execution/scans/scan_reconciler.go
Outdated
Comment thread
operator/apis/execution/v1/scan_types.go
Outdated
Comment thread
documentation/docs/api/crds/scan.md
Outdated
Comment thread
documentation/docs/api/crds/scan.md
…tomatic removal of scans Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Needed to record the completion time of the scan in order to automatically delete a scan Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
…d be deleted automatically Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Reet00
force-pushed
the
development-branch
branch
from
6437d1d to
aabce59
Compare
August 30, 2024 08:41
…was set checkIfTTLSecondsAfterFinishedisCompleted checks if the option was set and if the time has exceeded Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
…ed scans to be able to use this to determine the deletion time for errored scans Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com> Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com> Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Reet00
force-pushed
the
development-branch
branch
from
a3b8294 to
1b8c201
Compare
August 30, 2024 11:29
Copy link
Copy Markdown
|
Sorry, something went wrong.
J12934
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds ttlSecondsAfterFinished option to automatically delte finished and errored scans after a defined time in seconds. This will delete the specific scan and not just a scanner/parser job.
Also sets the finishedAt attribute to the timestamp a scan is marked as "Done" or "Errored".
Checklist