Drop axios from hook-sdk - #2977
Conversation
Sorry, something went wrong.
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sorry, something went wrong.
|
Sorry, something went wrong.
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
…dback Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
|
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR removes axios as a dependency from the hook-sdk and replaces it with the built-in fetch API. Key changes include:
- Removal of the axios dependency from package.json.
- Replacement of axios calls with fetch in hook-wrapper.js.
- Refactoring promise-based functions to async/await with updated error handling.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hook-sdk/nodejs/package.json | Removed axios dependency to reduce external dependencies. |
| hook-sdk/nodejs/hook-wrapper.js | Replaced axios calls with fetch and updated function signatures accordingly. |
hook-sdk/nodejs/hook-wrapper.js:38
- The 'content-type' header is set to an empty string. Please specify a valid content-type header (e.g., 'application/json' or other appropriate type) to ensure the server correctly interprets the uploaded file contents.
headers: { "content-type": "" },
Sorry, something went wrong.
Description
Drops axios from hook-sdk dependencies and switches to the build in fetch function.
Checklist