FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ensure Host findings still have a valid location even when they are not named by J12934 · Pull Request #3451 · secureCodeBox/secureCodeBox · GitHub

/ secureCodeBox Public

Ensure Host findings still have a valid location even when they are not named - #3451

Merged
Reet00 merged 2 commits into
secureCodeBox:mainfrom
J12934:fix/missing-location-for-hosts-findings-without-hostnames
Jan 9, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Ensure Host findings still have a valid location even when they are not named#3451
Reet00 merged 2 commits into
secureCodeBox:mainfrom
J12934:fix/missing-location-for-hosts-findings-without-hostnames

Conversation

J12934 commented Jan 7, 2026

Copy link
Copy Markdown
Member

Description

Noticed some nmap findings were missing locations which is kinda inconsistent

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

J12934 added 2 commits January 7, 2026 10:36
Ensure Host findings still have a valid location even when they are not
ba1b8d1 
named

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Update snapshots to include location for unnamed hosts
a5325d3 
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934 self-assigned this Jan 7, 2026
J12934 added the bug Bugs label Jan 7, 2026

netlify Bot commented Jan 7, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit a5325d3
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/695e2a397fca3c0008308a9a

sonarqubecloud Bot commented Jan 7, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Reet00 approved these changes Jan 9, 2026
View reviewed changes

Reet00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

github-project-automation Bot moved this from Triage to Reviewer Approved in secureCodeBox Jan 9, 2026
Reet00 merged commit 31d9ab0 into secureCodeBox:main Jan 9, 2026
50 checks passed
github-project-automation Bot moved this from Reviewer Approved to Done in secureCodeBox Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Reet00 Reet00 approved these changes

Assignees

J12934

Labels

bug Bugs

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL