FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix cascading-hooks labels by aveyrenc · Pull Request #3573 · secureCodeBox/secureCodeBox · GitHub

Fix cascading-hooks labels - #3573

Merged
J12934 merged 1 commit into
secureCodeBox:mainfrom
aveyrenc:fix-cascading-hooks-labels
Apr 7, 2026
Merged

Fix cascading-hooks labels#3573
J12934 merged 1 commit into
secureCodeBox:mainfrom
aveyrenc:fix-cascading-hooks-labels

Conversation

aveyrenc commented Mar 25, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

When supplying multiple labels for the cascading scans hook, we end up with an indention error.

Values:

hook:
  labels:
    app: securecodebox
    hooks: cascading

Result:

apiVersion: "execution.securecodebox.io/v1"
kind: ScanCompletionHook
metadata:
  name: release-name-cascading-scans
  labels:
    helm.sh/chart: cascading-scans-5.6.0
    app.kubernetes.io/name: cascading-scans
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/managed-by: Helm
    securecodebox.io/internal: "true"
    app: securecodebox
hooks: cascading
spec:
  priority: 100
  type: ReadOnly

As you can see, the hooks: cascading label is not indented.

This PR fixes labels indentation

netlify Bot commented Mar 25, 2026
edited
Loading

Copy link
Copy Markdown

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 92aca30
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/69d4f60ad4cccf000800d29d

Weltraumschaf moved this from Triage to To Review in secureCodeBox Mar 26, 2026
Signed-off-by: Alexandre Veyrenc <24861865+aveyrenc@users.noreply.github.com>
aveyrenc force-pushed the fix-cascading-hooks-labels branch from ee945ec to 92aca30 Compare April 7, 2026 12:18

sonarqubecloud Bot commented Apr 7, 2026

Copy link
Copy Markdown

J12934 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @aveyrenc sorry lost this out of my sight, looks good 👍

github-project-automation Bot moved this from To Review to Reviewer Approved in secureCodeBox Apr 7, 2026
J12934 merged commit 66652a9 into secureCodeBox:main Apr 7, 2026
48 checks passed
github-project-automation Bot moved this from Reviewer Approved to Done in secureCodeBox Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL