Use Multi-Stage-Build For Nikto - #642
Merged
nigthknight merged 3 commits intoSep 14, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
nigthknight
marked this pull request as draft
September 13, 2021 10:39
nigthknight
force-pushed
the
nikto-custom-dockerfile
branch
5 times, most recently
from
54a4575 to
90f1213
Compare
September 13, 2021 11:54
nigthknight
marked this pull request as ready for review
September 13, 2021 11:57
SebieF
previously approved these changes
Sep 13, 2021
Comment thread
scanners/nikto/scanner/Dockerfile
Outdated
nigthknight
force-pushed
the
nikto-custom-dockerfile
branch
from
15a5f45 to
2633c1b
Compare
September 13, 2021 12:40
J12934
reviewed
Sep 13, 2021
Comment thread
scanners/nikto/scanner/Dockerfile
Outdated
As described in #610 the build for nikto was quite complicated and could not be managed via matrix builds on GH. To Fix this I created a multi-stage Dockerfile that clones the nikto repo in the build stage and checks out the specified version. The next stage installs all dependencies like in the Dockerfile provided by the maintainer of nikto, copies nikto from the build stage and our wrapper script. I also noticed that the alpine version was a little behind so I changed it from 3.12 to 3.14 Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
With the new multi-stage image it should be possible to add nikto to the matrix build for 3rd-party scanners. So I removed the build job for nikto and added nikto to the matrix Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
nigthknight
force-pushed
the
nikto-custom-dockerfile
branch
from
2633c1b to
5be6d7b
Compare
September 13, 2021 12:58
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@protonmail.com>
SebieF
approved these changes
Sep 14, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If applied, this PR will:
Signed-off-by: Yannik Fuhrmeister yannik.fuhrmeister@iteratec.com