🚧 [Consistency] Making all scan-type.yaml files consistent - #703
Merged
J12934 merged 6 commits intoOct 15, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
1. Replacing all ' with " 2. Replacing incorrect scanner image ".Chart.Version" with ".Chart.AppVersion" 3. Replacing array command for ncrack, nmap, test-scan, whatweb with single lines for each parameter 4. Removing redundant comments 5. Adding missing empty lines 6. Make order of variables consistent for all scanners Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
J12934
requested changes
Oct 5, 2021
Comment thread
scanners/amass/templates/amass-scan-type.yaml
Comment thread
scanners/git-repo-scanner/templates/git-repo-scanner-scan-type.yaml
Outdated
Comment thread
scanners/kubeaudit/templates/kubeaudit-scan-type.yaml
This is done because these are our own scanners (SCB scanners) that follow our release versioning system. Regarding consistency, an issue was created to keep this in mind. Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
J12934
approved these changes
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #689.
Makes all scan-type-yaml files consistent:
Checklist