This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Add securityContexts to secureCodeBox Components - #129
Merged
nigthknight merged 17 commits intoOct 5, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The `nonroot` user assignment was removed from the dockerfile as this was already set via the `:nonroot` tag. This user is already set using its uid. This allows the `runAsNonRoot` securityContext Flag to work correctly.
This is more online with the parser and allows them to run in cluster with extremly high security requirements / or hard enforced multi tenancy. See: https://kubernetes.io/docs/concepts/containers/images/#use-cases
These will be extended later to best represent the needs of the individual scanners. Also added `env`, `extraVolumes`, `extraVolumeMounts`, `extraContainers` config values missing in scanner templates.
Copy link
Copy Markdown
Member
Author
|
While adding the securityContext i've noticed that all scanners had env, extraVolumes, extraVolumeMounts, extraContainers config values in their Helm values but their templates didn't really support them. I've added them to all integrated scanners. |
Sorry, something went wrong.
nigthknight
suggested changes
Oct 5, 2020
Comment thread
operator/README.md
Outdated
Comment thread
operator/README.md
Outdated
Comment thread
operator/README.md
Outdated
Comment thread
scanners/nmap/README.md
Outdated
Comment thread
scanners/nmap/README.md
Outdated
Comment thread
scanners/nmap/scanner/Dockerfile
Outdated
Comment thread
scanners/sslyze/templates/sslyze-scan-type.yaml
Outdated
Comment thread
scanners/test-scan/templates/test-scan-scan-type.yaml
Outdated
Comment thread
scanners/trivy/templates/trivy-scan-type.yaml
Outdated
Comment thread
scanners/wpscan/templates/wpscan-scan-type.yaml
Outdated
nigthknight
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable Kubernetes securityContext to all included pods.
For all direct "secureCodeBox" components (Operator, Lurcher, Parser & Hooks) these are completely pre-configured to enable all securityContext features which are generally available on all supported Kubernetes Versions.
For the scanner container these have not yet been configured, as this might required more tweaking to properly support the individual scanner without messing with their functionality. For now only Nmap has been configured with a proper securityContext. As the securityContext is exposed via the Helm values it can be configured individually by the user.