FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix NPM deployment by kevin-brown · Pull Request #5686 · select2/select2 · GitHub

Fix NPM deployment - #5686

Merged
kevin-brown merged 2 commits into
developfrom
npm-deployment
Oct 31, 2019
Merged

Fix NPM deployment#5686
kevin-brown merged 2 commits into
developfrom
npm-deployment

Conversation

Copy link
Copy Markdown
Member

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

  • Fix the incorrect NPM registry during that deployment step

If this is related to an existing ticket, include a link to it as well.

This changes the NPM registry URL to point to the actual NPM registry
instead of the GitHub package registry.
This should hopefully fix any possible issues where the NPM package
may be released after the documentation is deployed, which could cause
a cause miss by jsDelivr and cause the documentation to cache without
pulling in the Select2 dependency.

It hasn't happened yet, but I'm concerned it could happen and I don't
want to put in the effort to make a more sophisticated way of
handling this issue.
kevin-brown added this to the 4.0.12 milestone Oct 31, 2019
kevin-brown merged commit 0d37eed into develop Oct 31, 2019
kevin-brown deleted the npm-deployment branch October 31, 2019 03:38
maxwellfet928 pushed a commit to maxwellfet928/select2 that referenced this pull request Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL