Only trigger 'selection:update' once on DOM change events - #5734
Merged
kevin-brown merged 5 commits intoJan 28, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Is it possible to add a test that covers this change? It would probably be similar to the existing DOM integration tests, but for handling multiple changes. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Happy to give it a try, yes. Should I just be testing that selection:update only happens once? Kind of tricky without making the test "wait" for a little bit to check it doesn't get called more than once. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The test I've added fails before my change, but I'm not sure how useful the test case is... Let me know your thoughts |
Sorry, something went wrong.
Because we're still doing best-effort IE8 support for some reason.
This was referenced Apr 8, 2020
maxwellfet928
pushed a commit
to maxwellfet928/select2
that referenced
this pull request
Jun 8, 2026
* Only trigger 'selection:update' once on DOM change events * Fix linting errors * Add test for adding multiple options to a select * Switch Array.isArray to jQuery.isArray Because we're still doing best-effort IE8 support for some reason. * Fixed formatting in tests Co-authored-by: Kevin Brown <kevin-brown@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
I've had an issue when using select2 with datatables editor. I have a dropdown that has 4000+ elements, loaded via datatables editor and ajax. Everytime I filter/sort/change page on the table a new request fires to get the data the correct page, but also (annoyingly and seemingly unnecessarily) the list of options for the dropdown gets returned again... This then causes the page to become unresponsive as select2 goes through and refreshes the DOM (I think, it's certainly doing something along those lines) 4000+ times for each option being removed, and 4000+ times for each option being added.
This issue didn't exist before 4.0.3, and the below changes fix it. All tests are still passing, but I could very easily have overlooked something important though.