| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I'm going to evaluate the need for this soon as we are making some accessibility changes in the upcoming 4.1.0 release which would be a solid time for this pull request. Unfortunately it looks like this pull request includes changes to the dist directory which need to be reverted. We regenerate the dist periodically and including changes to that directory in pull requests causes the directory to quickly become out of sync with any code changes. |
Sorry, something went wrong.
|
Got it. Generally, other packages required the dist files to be included in the pull. |
Sorry, something went wrong.
|
Oh wait. This got closed somehow. I messed up my fork and did hard reset it to this branch. I've committed the changes. |
Sorry, something went wrong.
|
I'm pretty sure we need this for the dropdown search, and for consistency it probably makes sense to have it for the selection search as well (when the dropdown is open). The main changes that need to happen are:
|
Sorry, something went wrong.
|
Hey @kevin-brown, I've made the changes as mentioned. I've also added the test cases. |
Sorry, something went wrong.
…#5824) * Add aria-label 'Search' to search input when dropdown opens. * Fixex per review comments. Added test cases.
…#5824) * Add aria-label 'Search' to search input when dropdown opens. * Fixex per review comments. Added test cases.
| Back | FazBrowse Home | New Git URL |
This pull request includes a
The following changes were made:
I've added an aria-label to the search box when dropdown opens. I've added a translation function for the label so that it can be set as per the language.