Add aria-controls attribute for combobox to fix accesibility issue - #5942
Merged
kevin-brown merged 1 commit intoJan 5, 2021
Merged
Add aria-controls attribute for combobox to fix accesibility issue#5942kevin-brown merged 1 commit into
kevin-brown merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anttikuuskoski
pushed a commit
to anttikuuskoski/select2
that referenced
this pull request
Mar 29, 2022
Copy link
Copy Markdown
|
I believe that this fix does remove the "Element with role attribute has required states and properties" flag in a11y checkers, but should the id associated with aria-controls on the combobox instead be attached tot he corresponding listbox element? This MDN doc seems to suggest that's the correct use of aria-controls in the case of combobox. So in the case of this combobox, the id associated with the aria-controls would be select2-edit-field-topic-target-id-results instead of select2-edit-field-topic-target-id-container. |
Sorry, something went wrong.
maxwellfet928
pushed a commit
to maxwellfet928/select2
that referenced
this pull request
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
If this is related to an existing ticket, include a link to it as well.