FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: set target_commitish when creating a GitHub release by wingyplus · Pull Request #305 · semantic-release/github · GitHub

feat: set target_commitish when creating a GitHub release - #305

Merged
gr2m merged 1 commit into
semantic-release:masterfrom
wingyplus:iss-304
Nov 17, 2020
Merged

feat: set target_commitish when creating a GitHub release #305
gr2m merged 1 commit into
semantic-release:masterfrom
wingyplus:iss-304

Conversation

wingyplus commented Nov 16, 2020
edited by hearts Bot
Loading

Copy link
Copy Markdown
Contributor

Closes #304

gr2m commented Nov 16, 2020
edited by hearts Bot
Loading

Copy link
Copy Markdown
Member

can you please rebase on latest master? We just fixed the CI setup.

Change looks good, but can you please adapt the tests accordingly?

wingyplus changed the title Set git_commitish when creating GitHub release feat: set target_commitish when creating a GitHub release Nov 17, 2020

wingyplus commented Nov 17, 2020
edited by hearts Bot
Loading

Copy link
Copy Markdown
Contributor Author

@gr2m Test was added and commit message change to follows the pattern. :)

gr2m left a comment
edited by hearts Bot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great, thank you!

gr2m merged commit a54e596 into semantic-release:master Nov 17, 2020

Copy link
Copy Markdown

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

wingyplus deleted the iss-304 branch November 18, 2020 04:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set branch name to target_commitish

3 participants


Back | FazBrowse Home | New Git URL