chore: drop aggregate-error dependency in favor of native object - #943
Open
mcmxcdev wants to merge 1 commit into
Open
mcmxcdev wants to merge 1 commit into
mcmxcdev wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- uninstall aggregate-error dependency - remove AggregateError import from success.js and verify.js files
mcmxcdev
marked this pull request as ready for review
October 16, 2024 18:57
Copy link
Copy Markdown
Author
|
@travi Any interest in getting this old PR merged? Otherwise I would close it to clean up my open PR queue. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Motivation
https://www.npmjs.com/package/aggregate-error notes that "With Node.js 15, there's now a built-in AggregateError type."
Since this package specifies "node": ">=20.8.1" as engines requirement, we should be able to drop this dependency without any issues.