FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Exclude test package by irushchyshyn · Pull Request #300 · sendgrid/sendgrid-python · GitHub

/ sendgrid-python Public

Exclude test package - #300

Merged
SendGridDX merged 1 commit into
sendgrid:masterfrom
irushchyshyn:patch-1
Mar 30, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Exclude test package#300
SendGridDX merged 1 commit into
sendgrid:masterfrom
irushchyshyn:patch-1

Conversation

irushchyshyn commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Sendgrid tests are installed into <python_sitelib>/test which may cause conflicts with other packages. We have run into this when building a package for Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1309244)

The solution would be to either exclude tests or install them under sendgrid directory (<python_sitelib>/sendgrid/test).

thinkingserious commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Hello @irushchyshyn,

Thank you for the PR!

We will be reviewing this PR soon, in the mean time, if you have not, please be sure to sign our CLA so that we can merge your changes. Thanks again!

Team DX

thinkingserious added status: code review request requesting a community code review or review from Twilio status: cla needed labels Mar 28, 2017

thinkingserious commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Hi @irushchyshyn,

I think this is a good solution, could you please sign our CLA so I can merge it? Thanks!

irushchyshyn commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for review @thinkingserious ! CLA signed and sent.

SendGridDX mentioned this pull request Mar 29, 2017
Closed

SendGridDX commented Mar 29, 2017

Copy link
Copy Markdown

@irushchyshyn,

Yesterday, we launched a new, much easier CLA system. All you need to now is click a button and you are done!

Please take a moment to do so here. Thanks!

With Best Regards,

Elmer

irushchyshyn commented Mar 29, 2017

Copy link
Copy Markdown
Contributor Author

Thanks @SendGridDX ! Done.

Exclude test package
739d6df 
Sendgrid tests are installed into `<python_sitelib>/test` which may cause conflicts with other packages. We have run into this when building a package for Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1309244)

The solution would be to either exclude tests or install them under sendgrid directory (`<python_sitelib>/sendgrid/test`).

SendGridDX commented Mar 29, 2017 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

SendGridDX mentioned this pull request Mar 30, 2017
Closed
SendGridDX merged commit c83f10e into sendgrid:master Mar 30, 2017

SendGridDX commented Mar 30, 2017

Copy link
Copy Markdown

Thanks again @irushchyshyn for the PR,

Please take a moment to fill out this form so that we can send you some swag :)

With Best Regards,

Elmer

thinkingserious added a commit that referenced this pull request Mar 30, 2017
Version Bump v3.6.5: #300 Exclude test package
57d6e16
irushchyshyn deleted the patch-1 branch April 29, 2018 18:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL