FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allows users to submit rfc822 formatted email addresses by mbernier · Pull Request #348 · sendgrid/sendgrid-python · GitHub

/ sendgrid-python Public

Allows users to submit rfc822 formatted email addresses - #348

Merged
thinkingserious merged 10 commits into
masterfrom
issue_277
Oct 23, 2017
ConversationCommits (10)ChecksFiles changed
Merged

Allows users to submit rfc822 formatted email addresses#348
thinkingserious merged 10 commits into
masterfrom
issue_277

Conversation

mbernier commented Oct 1, 2017

Copy link
Copy Markdown
Contributor

Closes #277

SendGridDX commented Oct 1, 2017 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 1, 2017

mbernier commented Oct 2, 2017

Copy link
Copy Markdown
Contributor Author

@thinkingserious I am not sure what happened with the Travis build... looks like there's an env problem?

thinkingserious requested changes Oct 2, 2017
View reviewed changes
Comment thread sendgrid/helpers/mail/mail.py Outdated
self.email = email
if name is not None:
self.name = name
if not name

thinkingserious Oct 2, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should be if not name:

mbernier commented Oct 2, 2017

Copy link
Copy Markdown
Contributor Author

Updated, thanks!

missing a colon -
8d24621 
Also realized, we already checked that name exists... so we don't have to check again
Changed all access methods to use get/set, initialize name/email
84d81bb 
The class was not using get/set methods for all calls. As well, email and name were not initialized. This is now rectified.
mbernier mentioned this pull request Oct 19, 2017
Closed
This was referenced Oct 19, 2017
Closed
Closed
Closed
Closed
Closed
mbernier pushed a commit that referenced this pull request Oct 19, 2017
This is failing in #348
e784175 
My guess is this should be one line?
mbernier mentioned this pull request Oct 19, 2017
Merged
thinkingserious added a commit that referenced this pull request Oct 20, 2017
Merge pull request #400 from sendgrid/mbernier-patch-2
75ccf42 
This is failing in #348

codecov-io commented Oct 22, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #348 into master will increase coverage by 0.43%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   81.54%   81.98%   +0.43%     
==========================================
  Files           9        9              
  Lines         981      999      +18     
  Branches      156      160       +4     
==========================================
+ Hits          800      819      +19     
  Misses         90       90              
+ Partials       91       90       -1
Impacted Files Coverage Δ
sendgrid/helpers/mail/mail.py 88.27% <100%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0884519...3f876af. Read the comment docs.

Merge branch 'master' of https://github.com/sendgrid/sendgrid-python …
d483214 
…into issue_277
added unittests and updated Email class
3f876af 
email class now allows empty instantiation without error
If a name is passed, i.e. an email with no '@', then the name gets set rather than defaulting to email param

mbernier commented Oct 23, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@thinkingserious I added a ridiculous number of tests and even found something I missed. You win. Fine. Are you happy!!? 🥇

thinkingserious merged commit ae54113 into master Oct 23, 2017

thinkingserious commented Oct 23, 2017

Copy link
Copy Markdown
Contributor

Hello @mbernier,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Oct 23, 2017
Version Bump v5.3.0: #348: Allows users to submit rfc822 formatted em…
4302bff 
…ail addresses
mbernier deleted the issue_277 branch October 24, 2017 15:18

mbernier commented Oct 24, 2017

Copy link
Copy Markdown
Contributor Author

It's MERGED!!!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

thinkingserious thinkingserious approved these changes

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL