FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Test to check year in LICENSE.txt by navinpai · Pull Request #480 · sendgrid/sendgrid-python · GitHub

/ sendgrid-python Public

Test to check year in LICENSE.txt - #480

Merged
mbernier merged 2 commits into
sendgrid:masterfrom
navinpai:license_test
Nov 1, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Test to check year in LICENSE.txt#480
mbernier merged 2 commits into
sendgrid:masterfrom
navinpai:license_test

Conversation

navinpai commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

Fixes

Fixes #474

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added a test to ensure license year is current
  • Test currently fails because MASTER has 2012-2016, which has been rectified by Updated the license file #477

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017

mbernier commented Nov 1, 2017

Copy link
Copy Markdown
Contributor

Well done! Thank you!

mbernier merged commit 7cf38ca into sendgrid:master Nov 1, 2017

thinkingserious commented Nov 1, 2017

Copy link
Copy Markdown
Contributor

Hello @navinpai,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

mbernier commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

@navinpai

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range

4 participants

Back | FazBrowse Home | New Git URL