FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Few typos and grammatical mistake corrected by yudhik11 · Pull Request #57 · sendgrid/smtpapi-python · GitHub

/ smtpapi-python Public

docs: Few typos and grammatical mistake corrected - #57

Merged
childish-sambino merged 2 commits into
sendgrid:mainfrom
yudhik11:patch-1
Sep 21, 2020
ConversationCommits (2)ChecksFiles changed
Merged

docs: Few typos and grammatical mistake corrected#57
childish-sambino merged 2 commits into
sendgrid:mainfrom
yudhik11:patch-1

Conversation

yudhik11 commented Oct 31, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017

SendGridDX commented Oct 31, 2017 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

yudhik11 commented Nov 1, 2017

Copy link
Copy Markdown
Contributor Author

My pull request for removing grammatical mistakes is still pending.

mbernier commented Nov 3, 2017

Copy link
Copy Markdown
Contributor

@yudhik11

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty labels Feb 27, 2018
misterdorm added status: ready for merge code deemed fit for merge and removed status: code review request requesting a community code review or review from Twilio labels Oct 31, 2018
childish-sambino removed the type: community enhancement feature request not on Twilio's roadmap label Jul 20, 2020
thinkingserious changed the base branch from master to main July 28, 2020 14:37
childish-sambino changed the title Few typos and grammatical mistake corrected docs: Few typos and grammatical mistake corrected Sep 21, 2020
childish-sambino merged commit 8dfb657 into sendgrid:main Sep 21, 2020
childish-sambino removed the status: ready for merge code deemed fit for merge label Sep 21, 2020
yudhik11 deleted the patch-1 branch September 23, 2020 04:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

misterdorm misterdorm approved these changes
+1 more reviewer
childish-sambino childish-sambino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL