FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Correct *.md files using Grammarly by myzeprog · Pull Request #70 · sendgrid/smtpapi-python · GitHub

/ smtpapi-python Public

docs: Correct *.md files using Grammarly - #70

Merged
childish-sambino merged 2 commits into
sendgrid:mainfrom
myzeprog:fix-issue-69
Aug 13, 2020
ConversationCommits (2)ChecksFiles changed
Merged

docs: Correct *.md files using Grammarly#70
childish-sambino merged 2 commits into
sendgrid:mainfrom
myzeprog:fix-issue-69

Conversation

myzeprog commented Oct 5, 2018

Copy link
Copy Markdown
Contributor

Fixes #69

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Correcting *.md files using Grammarly

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
myzeprog force-pushed the fix-issue-69 branch 4 times, most recently from ca02694 to 586e9ec Compare October 7, 2018 18:22
misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty hacktoberfest and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018

misterdorm commented Oct 11, 2018

Copy link
Copy Markdown

#75 will fix the Travis failures.

misterdorm requested changes Oct 11, 2018
View reviewed changes

misterdorm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM after rebasing after #75 merged.

codecov Bot commented Oct 13, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@07ca62c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage        ?   99.32%           
=======================================
  Files           ?        2           
  Lines           ?      149           
  Branches        ?        0           
=======================================
  Hits            ?      148           
  Misses          ?        1           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ca62c...6bcb359. Read the comment docs.

myzeprog commented Oct 13, 2018

Copy link
Copy Markdown
Contributor Author

@misterdorm I made rebase and resolved all conflicts, Thanks

thinkingserious added status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018

thinkingserious commented Oct 22, 2018

Copy link
Copy Markdown
Contributor

Hello @myzeprog,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

misterdorm added status: ready for merge code deemed fit for merge and removed status: code review request requesting a community code review or review from Twilio labels Oct 31, 2018
childish-sambino removed the type: docs update documentation change not affecting the code label Jul 20, 2020
thinkingserious changed the base branch from master to main July 28, 2020 14:37
childish-sambino changed the title Correcting *.md files using Grammarly docs: Correct *.md files using Grammarly Aug 13, 2020
childish-sambino merged commit e4e3400 into sendgrid:main Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

misterdorm misterdorm approved these changes
+1 more reviewer
childish-sambino childish-sambino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: ready for merge code deemed fit for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run our *.md documents in this repo through the Grammer.ly service and update

4 participants

Back | FazBrowse Home | New Git URL