FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clearup type and documentation by zyc9012 · Pull Request #15 · serpapi/serpapi-javascript · GitHub

/ serpapi-javascript Public

Clearup type and documentation - #15

Merged
zyc9012 merged 5 commits into
masterfrom
cleanup
Jun 28, 2023
ConversationCommits (5)ChecksFiles changed
Merged

Clearup type and documentation#15
zyc9012 merged 5 commits into
masterfrom
cleanup

Conversation

zyc9012 commented Jun 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Remove all types for engine parameters and responses
  • Clear up documentation
  • Clarify that https://serpapi.com/search-api is the only source of truth for valid engines and parameters.
    • Both in documentation and editor hint.




zyc9012 marked this pull request as ready for review June 5, 2023 00:27
zyc9012 requested a review from aciddjus June 5, 2023 00:27
aciddjus approved these changes Jun 28, 2023
View reviewed changes

aciddjus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, @zyc9012 💯
LGTM!

zyc9012 merged commit ecea6dc into master Jun 28, 2023
zyc9012 deleted the cleanup branch June 28, 2023 09:46
zyc9012 mentioned this pull request Mar 31, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aciddjus aciddjus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL