Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
galetahub
requested changes
Aug 17, 2026
Comment thread
README.md
Outdated
|
|
||
| ## Change log | ||
|
|
||
| * Unreleased - Add Markdown search and archive output support |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I haven't released version 1.0.0 yet. Let's include this change in the first release.
Sorry, something went wrong.
Comment thread
tests/ClientTest.php
Outdated
| public function testMdReturnsRawMarkdown() | ||
| { | ||
| $markdown = "---\nengine: google\n---\n\n## Organic Results\n"; | ||
| $client = new StubClient([ |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Got this error in tests. It looks like the StubClient class isn't in this PR.
1) SerpApi\Tests\ClientTest::testMdReturnsRawMarkdown Error: Class "SerpApi\Tests\StubClient" not found
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes, forgot to include it, but now that I think about it it's not the right place to introduce stubbing, I will keep the test suite as is for now.
Sorry, something went wrong.
galetahub
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.