Add option for copying dependencies instead of creating a link - #685
Add option for copying dependencies instead of creating a link#685Psycholive wants to merge 3 commits into
Conversation
Sorry, something went wrong.
pgrzesik
left a comment
There was a problem hiding this comment.
Thanks @Psycholive - I have some comments, it also would be good to cover that functionality with a test case
Sorry, something went wrong.
| ```yaml | ||
| custom: | ||
| pythonRequirements: | ||
| useFinalCopy: true |
There was a problem hiding this comment.
I'm not sure if this property name is a great choice here - it doesn't really convey the meaning in my opinion - maybe we could use something more descriptive? Like useSymlinks: false or something along those lines? What do you think?
Sorry, something went wrong.
There was a problem hiding this comment.
Property naming is always a difficult task :) Why not useSymlinks indeed.
Sorry, something went wrong.
|
|
||
| Before final packaging, a link is created in .serverless folder for python dependencies. | ||
| If it is not possible to create a symbolic link, dependencies can be copied instead of linked | ||
| whith the foloowing option: |
There was a problem hiding this comment.
multiple typos
Sorry, something went wrong.
There was a problem hiding this comment.
Indeed.
Sorry, something went wrong.
|
Hey @Psycholive - sorry for not responding for a long time. Do you still have time to finalize this PR? |
Sorry, something went wrong.
I have a case where a windows folder containing sources is mounted in a linux VM and therefore symlinks cannot be created in .serverless folder.
This PR add a new option to copy dependencies in .serverless folder instead of creating a symlink. It is less beautiful and quick but it is the only option I see in my case.
It is possible to include this option in next release?