Make crate no_std compatible - #389
Conversation
Sorry, something went wrong.
|
It seems that the changes are not complete. I still find some deps need changes or default-features = false . |
Sorry, something went wrong.
|
I tested it with cargo build --no-default-features and cargo test with default features on purpose to use std. Is that what you tried? |
Sorry, something went wrong.
I built with --target armv7a-none-eabi (which does not have a std) and fixed some of the compilation errors. You can take a look at my branch. It also requires a dep change. |
Sorry, something went wrong.
|
Merged your branch as your PR for the dependency was merged and released. |
Sorry, something went wrong.
|
More changes are needed in the cssparser-color crate. My branch has been updated. |
Sorry, something went wrong.
emilio
left a comment
There was a problem hiding this comment.
looks ok, but can you rebase and add the license headers? Thanks
Sorry, something went wrong.
| serde = { version = "1.0", features = ["derive"], optional = true } | ||
| cssparser = { path = "..", default-features = false } | ||
| serde = { version = "1.0", default-features = false, features = ["derive"], optional = true } | ||
| libm = "0.2.8" |
There was a problem hiding this comment.
Ah, I missed this. It seems this dependency should be optional, and only enabled if std is disabled?
Sorry, something went wrong.
| [dependencies] | ||
| cssparser-macros = { path = "./macros", version = "0.6.1" } | ||
| dtoa-short = "0.3" | ||
| dtoa-short = "0.3.5" |
There was a problem hiding this comment.
Is this change needed?
Sorry, something went wrong.
| pub(crate) fn f32_trunc(val: f32) -> f32 { | ||
| #[cfg(feature = "std")] | ||
| { val.round() } | ||
| #[cfg(not(feature = "std"))] | ||
| { libm::roundf(val) } | ||
| } |
There was a problem hiding this comment.
This seems to be a typo. Should call into trunc function not round functions
Sorry, something went wrong.
Make crate no_std while keeping it backwards compatible with a default std feature enabled(only used to impl Error for ParseError).