Have mkstringprep.py download the RFC if it's missing - #2
Merged
sethmlarson merged 1 commit intoAug 12, 2026
Merged
sethmlarson merged 1 commit into
sethmlarson merged 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
encukou
commented
Aug 12, 2026
Comment thread
Tools/unicode/mkstringprep.py
| with open("rfc3454.txt") as f: | ||
| data = f.readlines() | ||
| try: | ||
| data_file = open(FILENAME, encoding='utf-8') |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
encoding='utf-8' might be cargo-culting (reportedly, non-ASCII-compatible encodings exist, but aren't really tested), but it's what makeunicodedata uses, and old Pythons don't use UTF-8 by default.
Sorry, something went wrong.
sethmlarson
approved these changes
Aug 12, 2026
sethmlarson
left a comment
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
Thanks Petr! 🙏
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
python#155293 adds a mkstringprep.py run to make regen-unicodedata. The existing script will download its data if a local copy is missing; mkstringprep should do the same.