FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change ID to v2ray-plugin with back compatibility by Mygod · Pull Request #21 · shadowsocks/v2ray-plugin-android · GitHub

Change ID to v2ray-plugin with back compatibility - #21

Merged
madeye merged 4 commits into
masterfrom
plugin-1.3.4
Feb 7, 2020
Merged

Change ID to v2ray-plugin with back compatibility#21
madeye merged 4 commits into
masterfrom
plugin-1.3.4

Conversation

Mygod commented Feb 4, 2020

Copy link
Copy Markdown
Collaborator

Mygod requested a review from madeye February 4, 2020 01:52

CzBiX commented Feb 4, 2020

Copy link
Copy Markdown

应该用 v2ray-plugin 当 id,v2ray 当 alias?
不然导出的时候还会是 v2ray,没法在其他平台使用了。

Mygod commented Feb 4, 2020

Copy link
Copy Markdown
Collaborator Author

shadowsocks-android will respect whichever is imported when exporting.

CzBiX commented Feb 4, 2020

Copy link
Copy Markdown

我是指用户在手机上编辑配置文件,选择了 v2ray 插件,然后导出的情况。

Mygod marked this pull request as ready for review February 5, 2020 04:40

Mygod commented Feb 5, 2020

Copy link
Copy Markdown
Collaborator Author

@CzBiX Accepted considering the file naming in shadowsocks/v2ray-plugin.

Mygod changed the title Add alias v2ray-plugin Change ID to v2ray-plugin with back compatibility Feb 5, 2020

Mygod commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator Author

@madeye Testing this change shouldn't require an update for plugin library. :)

madeye commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator

The new plugin has been released..

I guess the problem is the go version. I also updated the v2ray-plugin, which depends on go 1.13.

madeye merged commit cde826b into master Feb 7, 2020
Mygod deleted the plugin-1.3.4 branch February 7, 2020 07:57

Mygod commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator Author

We should release the main app first otherwise the alias thing will not be migrated smoothly.

madeye commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator

Sure, I'll release the shadowsocks app first.

Mygod commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator Author

Done fixing some issues in v5.0.3 now.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change plugin id from 'v2ray' to 'v2ray-plugin' for consistency

3 participants


Back | FazBrowse Home | New Git URL