FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Get Diagnostics Data API by dhlaluku · Pull Request #27 · shapeblue/cloudstack · GitHub

/ cloudstack Public
forked from apache/cloudstack

Get Diagnostics Data API - #27

Closed
dhlaluku wants to merge 1 commit into
mainfrom
retrieve-diagnostics-data
ConversationCommits (1)ChecksFiles changed
Closed

Get Diagnostics Data API#27
dhlaluku wants to merge 1 commit into
mainfrom
retrieve-diagnostics-data

Conversation

dhlaluku commented Nov 29, 2018 •
edited
Loading

Copy link
Copy Markdown

Get Diagnostics Data from system VMs
Docs; https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Get+Diagnostics+Data+API

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

dhlaluku force-pushed the retrieve-diagnostics-data branch from c06d256 to fa5379a Compare December 4, 2018 17:41
dhlaluku changed the base branch from master to 4.11 December 4, 2018 17:42
dhlaluku changed the base branch from 4.11 to master December 4, 2018 17:43
dhlaluku changed the base branch from master to 4.11 December 4, 2018 17:44
dhlaluku changed the base branch from 4.11 to master December 4, 2018 17:44
dhlaluku requested a review from nvazquez December 4, 2018 18:41
dhlaluku self-assigned this Dec 4, 2018
dhlaluku added this to the 4.12.0 milestone Dec 4, 2018
dhlaluku force-pushed the retrieve-diagnostics-data branch from 423d1c6 to 18b55a0 Compare December 5, 2018 06:12

borisstoyanov commented Jan 15, 2019

Copy link
Copy Markdown
Member

@dhlaluku this has been passed to me for testing but the title still says "work in progress"?

dhlaluku commented Jan 15, 2019

Copy link
Copy Markdown
Author

@borisstoyanov let me fix the merge conflict and remove the WIP from the label

dhlaluku force-pushed the retrieve-diagnostics-data branch from bbbe373 to fda69b2 Compare January 15, 2019 07:23
dhlaluku changed the title [WIP] Get Diagnostics Data API (for review) Get Diagnostics Data API Jan 15, 2019
dhlaluku changed the base branch from master to 4.11 January 15, 2019 07:26
dhlaluku changed the base branch from 4.11 to master January 15, 2019 07:27
dhlaluku force-pushed the retrieve-diagnostics-data branch from fda69b2 to ff46636 Compare February 25, 2019 08:07
DaanHoogland reviewed Mar 1, 2019
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

some questions and comments

Comment thread ...src/main/java/org/apache/cloudstack/api/command/admin/diagnostics/GetDiagnosticsDataCmd.java Outdated
Comment thread ...src/main/java/org/apache/cloudstack/api/command/admin/diagnostics/GetDiagnosticsDataCmd.java
Comment thread ...src/main/java/org/apache/cloudstack/api/response/diagnostics/GetDiagnosticsDataResponse.java
Comment thread core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
_eachTimeout = Duration.standardSeconds(cmd.getTimeout());
final ExecutionResult result = _vrDeployer.executeInVR(cmd.getRouterAccessIp(), VRScripts.RETRIEVE_DIAGNOSTICS, fileList, _eachTimeout);
if (result.isSuccess()){
return new PrepareFilesAnswer(cmd, true, result.getDetails());

DaanHoogland Mar 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

no validation of result.details?

dhlaluku Mar 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No validation required here, success/fail is handled in the service layer class "DiagnosticsServiceImpl"

dhlaluku Mar 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No need for validation here, script/command execution should be propagated back to service layer using command-answer pattern

Comment thread core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
Comment thread ...sors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java Outdated
Comment thread ...sors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java Outdated
* @param fileName filepath inside system vm, /root/diagnostics_files_xxxx.tar
*/
protected void cleanUpFileInVm(String vmIP, String fileName) {
final String PERM_KEY = "/root/.ssh/id_rsa.cloud";

DaanHoogland Mar 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please remove this here

dhlaluku Mar 10, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done, extracted Zip file in system vm file cleanup to Network element command which makes it hypervisor agnostic

Comment thread server/src/main/java/com/cloud/server/StatsCollector.java
return false;
}

public boolean imageStoreHasEnoughCapacity(DataStore imageStore, Double storeCapThreshold) {

DaanHoogland Mar 1, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

javadoc to explain how storeCapThreshold is used would be nice

Comment thread server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java Outdated
Comment thread server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java Outdated
dhlaluku pushed a commit that referenced this pull request Mar 12, 2019
Merge pull request #27 from shapeblue/dingane/fro210
1175081 
BT-HF66 Publish disk resize event in cloud_usage
dhlaluku force-pushed the retrieve-diagnostics-data branch from 679e170 to fbbee31 Compare March 19, 2019 15:28
* Complete API implementation
0b247be 
* Complete UI integration
* Complete marvin test
* Complete Secondary storage GC background task
dhlaluku force-pushed the retrieve-diagnostics-data branch from fbbee31 to 0b247be Compare March 21, 2019 10:34
shwstppr added a commit that referenced this pull request Nov 3, 2020
Volume migration fix wrt #22 (#27)
03d9cb5 
* fix worker vm

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove unwanted logs

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
dashboard improvements (#27)
f71ed85 
* Add new grid values new classes to replace inline stlyes with it

* Fix navigation scroll behavior

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr closed this in c9a75e2 Jan 20, 2021
yadvr reopened this Jan 20, 2021
shwstppr added a commit that referenced this pull request Aug 16, 2021
Volume migration fix wrt #22 (#27)
e7030a7 
* fix worker vm

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove unwanted logs

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

github-actions Bot commented Apr 8, 2022

Copy link
Copy Markdown

Hi @dependabot[bot], your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?

yadvr closed this Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland left review comments
nvazquez nvazquez left review comments
anuragaw Awaiting requested review from anuragaw
borisstoyanov Awaiting requested review from borisstoyanov

Assignees

dhlaluku

Labels

new feature status:has-conflicts

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL