FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Vmware migration test matrix by DaanHoogland · Pull Request #62 · shapeblue/cloudstack · GitHub

/ cloudstack Public
forked from apache/cloudstack

Vmware migration test matrix - #62

Open
DaanHoogland wants to merge 4 commits into
mainfrom
vmwareMigrationTestMatrix
ConversationCommits (4)ChecksFiles changed
Open

Vmware migration test matrix#62
DaanHoogland wants to merge 4 commits into
mainfrom
vmwareMigrationTestMatrix

Conversation

DaanHoogland commented Aug 27, 2020

Copy link
Copy Markdown
Member

Description

internal as it is not even draft yet. but opening to be able to discuss and extend

todo

  • define input matrix
  • slim preparations
  • define validations
  • ...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

borisstoyanov commented Aug 31, 2020

Copy link
Copy Markdown
Member

@DaanHoogland is this in final state now? I wonder if we can pick this up now

DaanHoogland commented Sep 3, 2020

Copy link
Copy Markdown
Member Author

@borisstoyanov @vladimirpetrov this is a frame for the tests that can be used and has to be expanded to include all tests. It is a starting point not a finished product.

DaanHoogland commented Sep 18, 2020

Copy link
Copy Markdown
Member Author

@vladimirpetrov can you add comments and code ?

DaanHoogland commented Sep 21, 2020
View reviewed changes
Comment thread test/integration/testpaths/testpath_migration_matrix.py
Comment on lines +20 to +21
from marvin.lib.base import ServiceOffering, Configurations, VirtualMachine, Account, Volume, DiskOffering, StoragePool, \
Role

DaanHoogland Sep 21, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think there is a more need line for a multiline import in python (/me googling ...)

Suggested change
from marvin.lib.base import ServiceOffering, Configurations, VirtualMachine, Account, Volume, DiskOffering, StoragePool, \
Role
from marvin.lib.base import (ServiceOffering,
Configurations,
VirtualMachine,
Account,
Volume,
DiskOffering,
StoragePool,
Role)

Comment thread test/integration/testpaths/testpath_migration_matrix.py
else:
print(">>> Current source datastore is the desired one - no need for setup")

# Migrate our volume to the target datastore

DaanHoogland Sep 21, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

same here, please extract to a method

Comment thread test/integration/testpaths/testpath_migration_matrix.py
target_pool = StoragePool.list(self.apiclient, name=target_name)[0]
voldata = volume.list(self.apiclient, id=volume.id)

# Move our volume to the source datastore

DaanHoogland Sep 21, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

having this comment indicates that we should have a method call here i.e. move_source_volume_to_source_datastore()
and then move the block below to a

    def move_source_volume_to_source_datastore(...)

DaanHoogland reopened this Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

borisstoyanov Awaiting requested review from borisstoyanov
vladimirpetrov Awaiting requested review from vladimirpetrov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL