Exclude log4j from transitive dependencies - #73
Merged
yadvr merged 1 commit intoFeb 4, 2022
Merged
yadvr merged 1 commit into
yadvr merged 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
yadvr
approved these changes
Feb 4, 2022
Copy link
Copy Markdown
|
Thanks Marcus, I'll merge the PR and we'll do a round of testing. |
Sorry, something went wrong.
yadvr
added a commit
that referenced
this pull request
Feb 8, 2022
* maven: migrate short-term to reload4j v1.2.18 This migrate to log4j 1.x fork, reload4j 1.2.18.0 which is drop-in replacement and addresses some immediate CVE and issues. * log4j migration to reload4j in pom xmls Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> * Exclude log4j from transitive dependencies (#73) Co-authored-by: Marcus Sorensen <shadowsor@gmail.com> Co-authored-by: Marcus Sorensen <mls@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excludes log4j from transitive dependencies
mvn dependency:tree -Dincludes=log4j:log4j:jar | grep log4j comes back clean after this, have not tested functionality though.