FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update readme, fix rare bug by adamgiesinger · Pull Request #9 · shapecode/fut-api · GitHub

/ fut-api Public

Update readme, fix rare bug - #9

Open
adamgiesinger wants to merge 2 commits into
shapecode:masterfrom
adamgiesinger:master
ConversationCommits (2)ChecksFiles changed
Open

Update readme, fix rare bug#9
adamgiesinger wants to merge 2 commits into
shapecode:masterfrom
adamgiesinger:master

Conversation

adamgiesinger commented Jan 24, 2020

Copy link
Copy Markdown
  • Fixed a bug that sometimes prevented the user from authenticating
  • Updated the README to match FIFA 20 parameters

nicklog reviewed Jan 24, 2020
View reviewed changes
Comment thread src/Api/AbstractCore.php
'redirect_uri' => 'https://www.easports.com/fifa/ultimate-team/web-app/auth.html',
// 'redirect_uri' => 'nucleus:rest',
'scope' => 'basic.identity offline signin basic.entitlement',
//'scope' => 'basic.identity offline signin basic.entitlement',

nicklog Jan 24, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Did you verify this by debugging the website?
At my last check this field was required.

adamgiesinger Jan 24, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I didn't debug the website but this resolved the issues I had on my MacBook while not breaking anything on my PC. Let me know if this doesn't work for you!

nicklog Jan 28, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would appreciate it if you would check this in the Chrome or Firefox debugger. Thank you very much.

lippl suggested changes May 3, 2020
View reviewed changes
Comment thread README.md
use FUTApi\Api\Authentication\Account;
use FUTApi\Api\Authentication\Credentials;
use FUTApi\Api\Authentication\Session;
use FShapecode\FUT\Client\Api\Core;

lippl May 3, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

isn't this a typo? changeuse FShapecode\FUT\Client\Api\Core; to use Shapecode\FUT\Client\Api\Core;

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicklog nicklog left review comments
+1 more reviewer
lippl lippl requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL