fix(exec): lockdown file permissions - #1060
Merged
nfischer merged 1 commit intoJan 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This locks down file permissions used by the internal implementation of `shell.exec()`. Issue #1058 Tested manually using the documented scenarios
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1060 +/- ##
=======================================
Coverage 97.14% 97.15%
=======================================
Files 35 35
Lines 1332 1335 +3
=======================================
+ Hits 1294 1297 +3
Misses 38 38 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
nfischer
added a commit
that referenced
this pull request
Jan 7, 2022
This locks down file permissions used by the internal implementation of `shell.exec()`. Issue #1058 Tested manually using the documented scenarios
7 tasks
This was referenced May 13, 2022
This was referenced May 17, 2022
This was referenced May 26, 2022
This was referenced May 6, 2022
This was referenced Mar 7, 2023
jchip
pushed a commit
to jchip/shcmd
that referenced
this pull request
Jun 23, 2024
This locks down file permissions used by the internal implementation of `shell.exec()`. Issue shelljs#1058 Tested manually using the documented scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This locks down file permissions used by the internal implementation of
shell.exec().
Issue #1058
Tested manually using the documented scenarios