fix: report chdir errors from cd - #1253
Open
lawrence3699 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
nfischer
approved these changes
May 2, 2026
Comment thread
test/cd.js
| t.is(result.stderr, 'cd: not a directory: test/resources/file1'); | ||
| }); | ||
|
|
||
| test('reports process.chdir() errors for existing directories', async t => { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can we rename this test case to "shell.cd() not supported in workers" or something like that?
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1253 +/- ##
=======================================
Coverage 97.09% 97.10%
=======================================
Files 36 36
Lines 1517 1519 +2
=======================================
+ Hits 1473 1475 +2
Misses 44 44 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1112.
When process.chdir() fails for an existing directory, cd() currently reclassifies the target as not a directory. In worker threads this hides Node's actual process.chdir() is not supported in workers error.
This keeps the existing no such file or directory and not a directory paths, but reports the original process.chdir() error when the target exists and is a directory.
Validation:
I also ran npm test; the cd tests passed, and the remaining local failures reproduced on a clean checkout before this change: chmod › Test setgid and four ls › long option assertions where this environment reports gid 0.