FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for local packages in nested xcode groups by TomaszLizer · Pull Request #30 · simonbs/dependency-graph · GitHub

Fix for local packages in nested xcode groups - #30

Open
TomaszLizer wants to merge 3 commits into
simonbs:mainfrom
TomaszLizer:fix-for-local-packages
Open

Fix for local packages in nested xcode groups#30
TomaszLizer wants to merge 3 commits into
simonbs:mainfrom
TomaszLizer:fix-for-local-packages

Conversation

Copy link
Copy Markdown

I have stumbled on issue where dependency-graph was not working for my project.
Afgter debugging in turned out that there were two main reasons:

  • Xcode project structure with local package (XCLocalSwiftPackageReference)
    Causing Error: The element XCLocalSwiftPackageReference is not supported. or zsh: segmentation fault dependency-graph TestDependency.xcodeproj #25 when running from console
    This is fixed by bumping XcodeProj to version that supports XCLocalSwiftPackageReference
  • Local Package in prject structure which is nested in group. Since each group shares its own path, then path of package in such group as it was created previously did not accomodated for skipped path components of other groups.
    Eg PackageB which resides in group NestedPackages was recognized other be in <root>/PackageB instead of root/NestedGroup/PackageB.
    This is fixed by utlising fullPath from XcodeProj.

Some other issues might be related to this fix as well, eg:

Updated tests to reflect those changes - since bug was in live path validation of XcodeProjectParserLive -> I have added FileSystemLive to two tests to take that part into account.
Additionally I have updated main example prioject as well as its copy to reflect those changes in tests.

TomaszLizer requested a review from simonbs as a code owner December 17, 2024 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL