FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Metadata Directory of FlatFiles support by pkolmann · Pull Request #1292 · simplesamlphp/simplesamlphp · GitHub

/ simplesamlphp Public

Add Metadata Directory of FlatFiles support - #1292

Open
pkolmann wants to merge 3 commits into
simplesamlphp:masterfrom
pkolmann:MetadataDirectoryOfFiles
ConversationCommits (3)ChecksFiles changed
Open

Add Metadata Directory of FlatFiles support#1292
pkolmann wants to merge 3 commits into
simplesamlphp:masterfrom
pkolmann:MetadataDirectoryOfFiles

Conversation

pkolmann commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

I like to split up long config files to split config files.

The MetaData Files usually are quite long and if you need to change
something it's quite bulky to handle them. Diffing between different SPs
is also not too easy.

Thats why I added the support for Metadata config directories. Every SP
goes into it's own flatfile.

I like to split up long config files to split config files.
a5d0b05 
The MetaData Files usually are quite long and if you need to change
something it's quite bulky to handle them. Diffing between different SPs
is also not too easy.

Thats why I added the support for Metadata config directories. Every SP
goes into it's own flatfile.
add directory to simplesamlphp-maintenance.md
4bf987b
remove debug output
35b2aa5

codecov Bot commented Feb 26, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.00%. Comparing base (d889cdd) to head (35b2aa5).
⚠️ Report is 2120 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1292      +/-   ##
============================================
+ Coverage     37.85%   38.00%   +0.15%     
- Complexity     3431     3446      +15     
============================================
  Files           129      130       +1     
  Lines          9738     9778      +40     
============================================
+ Hits           3686     3716      +30     
- Misses         6052     6062      +10
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pkolmann commented Feb 26, 2020

Copy link
Copy Markdown
Contributor Author

@tvdijen can you please advise if this change is worth accepting?
Thanks
Philipp

tvdijen commented Feb 26, 2020

Copy link
Copy Markdown
Member

Thanks @pkolmann!! I am
In transit from Madrid to The Hague now.. hopefully I can get back to you tomorrow.. I like the general idea of the pr though!

pkolmann commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

@tvdijen could you take another look at this please.

tvdijen force-pushed the master branch 3 times, most recently from 1c686ab to eb20457 Compare August 17, 2020 20:43
tvdijen mentioned this pull request Aug 21, 2020
Open
tvdijen force-pushed the master branch 2 times, most recently from 08ebb9c to 64fca25 Compare July 2, 2021 14:12
tvdijen force-pushed the master branch 2 times, most recently from 7a53fc8 to d73ae47 Compare September 26, 2021 13:03
tvdijen force-pushed the master branch 2 times, most recently from e5c0e21 to d5616df Compare January 9, 2022 11:00
tvdijen force-pushed the master branch 3 times, most recently from 2e6ab04 to 32f9acc Compare November 23, 2022 18:24
tvdijen force-pushed the master branch 6 times, most recently from 7e3ea19 to 2523634 Compare January 5, 2023 16:31

ebeuerle commented Jan 13, 2023

Copy link
Copy Markdown

@tvdijen Any luck with merging this PR? This would very handy to have for larger installations...

tvdijen force-pushed the master branch 2 times, most recently from 8ac729b to a16cf6e Compare April 25, 2023 08:33
tvdijen force-pushed the master branch 2 times, most recently from fc454de to 7ac76ae Compare May 3, 2023 08:31
tvdijen force-pushed the master branch 6 times, most recently from 29f7b69 to 1a911ce Compare May 12, 2023 16:07
tvdijen force-pushed the master branch 3 times, most recently from c7c8357 to fdbe001 Compare June 12, 2023 14:28
tvdijen force-pushed the master branch 8 times, most recently from 3b5f5ba to 96357ee Compare July 19, 2023 12:37
tvdijen force-pushed the master branch 3 times, most recently from cf19ac3 to d6b52c5 Compare July 31, 2023 12:30

monkeyiq commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

There is also an issue submitted wanting a similar functionality for the XML files for SPs. A comment over on that issue is calling for a more generic solution to allow both flatfile and xml to be loaded on demand: #1368 (comment)

I mention this because the comment may not have been seen on this thread. I've been looking at this PR and the code a little bit in recent days.

monkeyiq commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

I had a bit of a play around with this and ended up with very similar code to what is here though trying to handle xml files as well if they are found in the metadata/subdirectory.d directory. I am not sure what I have in the below branch makes complete sense as I am very new to the SSP code base.

https://github.com/monkeyiq/simplesamlphp/blob/c23a35a2ea33304de92331bba3962394f02feb66/src/SimpleSAML/Metadata/MetaDataStorageHandlerDirectory.php#L120

It does seem that this PR could be extended to check for php files and do something on them and something else if an xml file was found, otherwise maybe just report an ignored file?

monkeyiq mentioned this pull request Mar 4, 2024
Closed
monkeyiq mentioned this pull request Mar 20, 2024
Merged

monkeyiq commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

Sorry about the wait. I have merged a PR with this functionality into the simplesamlphp-2.3 branch and master.

#2018

The patch should also back port to a 2.2 release reasonably well if you would like to take it for a test run.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL