Minor modifications - #2
Open
mam10eks wants to merge 4 commits into
Open
mam10eks wants to merge 4 commits into
mam10eks wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
maumueller
reviewed
Jul 6, 2026
Comment thread
eval.py
| print(dataset, task, attrs.get("algo"), attrs.get("params"), "=>", recall) | ||
| row["recall"] = recall[0] | ||
| row["recall_description"] = recall[1] | ||
| add_details_from_tira(fn, row) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This should be guarded by a flag parsed as command line argument
Sorry, something went wrong.
maumueller
reviewed
Jul 6, 2026
Comment thread
eval.py
| recall = get_recall(knns, gt_I, k) | ||
| row = dict(attrs) | ||
| row["recall"] = recall | ||
| print(dataset, task, attrs.get("algo"), attrs.get("params"), "=>", recall) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Wasn't that rather helpful? :-) to see the progress?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor modifications to add more details to the json results and to write a temporary cache file to speed up the csv creation. (the evaluation otherwise runs hours on task 1)