| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Actually, I wasn't thinking right - the fact that the interface is in org.json has no bearing on the access to org.json from implementers. So this change seems even safer, as the only thing that will change is the package location. |
Sorry, something went wrong.
|
Thanks for your submission. This should be address in #194. A few more things were needed to make the change, including handling the change of JSONException to a RuntimeException. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This removes the org.json package as it's a split package with the one in android-json, fixing usages in the module system introduced in Java 9.
JSONString has been moved to org.skyscreamer.jsonassert. As far as I can tell, the reason this was in a split package to begin with is to allow JSONString implementers to have access to package-private methods in android-json's org.json.
The package-private methods/fields are:
So if you wanted to create your own "JSONThing", these methods are clearly pretty useful. I don't know how common it is to do this, but I imagine most consumers are just using JSONAssert, like Spring does. I'd argue that anyone using these package-private methods is skilled enough to just make them accessible via reflection, so while this is a breaking change, I don't think it's that bad.
Given it is a breaking change however, maybe this PR can be targeted to a 2.0 release? I'm not sure how committed you are to semantic versioning, but I'm pretty indifferent as long as this gets merged :). Thanks!